when was all that is gold does not glitter written

The line “All that is gold does not glitter” wasn’t written in our real world history, but rather created for the fictional world of J.R.R. Tolkien’s “The Lord of the Rings.”

The character Bilbo Baggins is credited with composing the riddle within the story. The book, “The Fellowship of the Ring,” the first part of the trilogy, was published in 1954. So, while the line itself isn’t tied to a specific real-world date, it appeared within that novel in 1954.